Code Review - latest github flow.
Reviewer will not merge the code to production. when reviewing changes, use the built-in Approve option in gitHub:
When performing CR, add your comments to the review. in the code click the "plus" sign in the start of the relevant line, and add your comments :
Code Review - Our Guidlines.
We're taking the "Cold" Code Review approach.
This means we're aware that the review is never personal, and must be look at as an opportunity to share knowledge and make informed engineering decisions.
We're also seek minimal verbal explenation to the code, so the reviewer can review the code as is, without presumptions regarding what the code is doing.
It is important to articulate your feedback carefully and keep in mind a constructive criticism point of view.Use tools for the boring parts
keep in mind that to check indentation for example or to run the code through EsLint to make sure conventions are followed can be done with tools and save time.Treat Code Reviews as a high priority
Keep in mind that if we're asked to code review it is likely taht the author is blocked on other work until the review is complete.
This goes out to the author and the reviewer.
The author should seek to make the changelist narrowly scoped, thus makes the review easier and more pleasant, and make it essentialy faster.Be generious and friendly.
In an ideal world, code review is an opportunity to learn and get better. In reality, we are sometimes under pressure to meet deadline or preceiving critics negatively. so to make the autho trust that your feedback is well-intentioned consider giving code examples (great gift), use the word we instead of you when commenting and sugguest solutions as "another approach might be..." .
*Branches Workflow reminder (also avaialbel in Environments page)
Our new branch naming should be as follow
New branch name should be like so: "fix-or-feature_CV-XXXX_short-description"
Dev branch that is branching out from the new name as seen above can stay like it was: "CV-XXX-dev"